Repository navigation
Fix C++17 lambda capture breaking HIP server builds - #939
Merged
Merged
Conversation
cunba-ai
pushed a commit
to cunba-ai/audio.cpp
that referenced
this pull request
Oct 28, 2026
…precision + WebUI voice listing + RKNN docs Upstream commits 0fdc572..498d4ae (14): - fix(build): gate family tests on the linked model set (0xShug0#925) - f5_tts CPU passes inside graph pool ceiling; evicted graphs freed (0xShug0#924) - Qwen3-TTS spec description trim; Inflect v2 ONNX prefix strip (0xShug0#933) - CPU Fish DAC reference-encoder tensor layouts (0xShug0#936) - Fish codec CUDA encoder precision aligned with Python (0xShug0#937) - C++17 lambda capture fix in parallel server unload (0xShug0#939) - fix(build): model unit tests compile their own family sources (0xShug0#932) - fix(build): split compiled-in model specs into 16KB literals (0xShug0#934) - webui: list/preview server voices (0xShug0#941,0xShug0#943); RKNN docs + IOVA ceiling (0xShug0#945,0xShug0#949)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid capturing a structured-binding variable in the parallel server unload lambda, which is not valid C++17.
Apply the fix suggested by the reporter: iterate over the entry and declare ordinary
idandmodellocals. Locking, queueing, deduplication and unload behavior are unchanged. No workflow or build-flag changes.Fixes #938.
Validation
-std=c++17 -Wpedantic -pedantic-errors: full model set, CLI, server, GGUF tool and enabled unit-test targets all compile.